Include Id, from the chema to be used in the Property Model and Class model, #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoSuter
reviewed
Jul 23, 2019
| _settings = settings; | ||
| _resolver = typeResolver; | ||
|
|
||
| Id = property.Id; |
Owner
There was a problem hiding this comment.
Id = property.Id ?? property.ActualSchema.Id;
Can a property have its own id?
Maybe also use a derived property like the Name?
| .Select(property => new PropertyModel(this, property, _resolver, _settings)) | ||
| .ToArray(); | ||
|
|
||
| Id = _schema.Id; |
Owner
There was a problem hiding this comment.
Use a derived/calculated property?
Owner
|
Add some tests? |
Owner
|
What is the schema/property id? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate the models we need to have the ID of the property and the class.-
I Extended the PropertyModel and ClassTemplateModel to include the Id.
Property respects the inheritance.